Fix 2605, Pass the CMAKE_PREFIX_PATH to targets #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
added
CCB:Approved
|
Thank you @renn0xtek9 for your contribution! Would you be able to fill out a CLA (Contributor License Agreement) and email it to [email protected] and copy [email protected]? Please let me know if you have any questions about the CLA. |
|
Thanks for you feddback @dzbaker ! I have sent the CLA to [email protected] on september 24th 2024. Let me forward the E-mail to [email protected] and to you 👍 |
renn0xtek9
force-pushed
the
fix-2605-Pass-CMAKE_PREFIX_PATH-to-targets
branch
from
ce88ac6
to
d436bbc
Compare
Excellent, thank you! |
renn0xtek9
force-pushed
the
fix-2605-Pass-CMAKE_PREFIX_PATH-to-targets
branch
from
d436bbc
to
31c8405
Compare
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 3, 2024
*Combines:* cFE equuleus-rc1+dev205 to_lab equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2602 - nasa/cFE#2606 *to_lab* - nasa/to_lab#171 - nasa/to_lab#180 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Maxime Haselbauer <[email protected]> Co-authored by: Anh Van <[email protected]>
This was referenced Oct 3, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 3, 2024
*Combines:* cFE equuleus-rc1+dev205 to_lab equuleus-rc1+dev62 **Includes:** *cFE* - nasa/cFE#2602 - nasa/cFE#2606 *to_lab* - nasa/to_lab#171 - nasa/to_lab#180 Co-authored by: Avi Weiss <[email protected]> Co-authored by: Maxime Haselbauer <[email protected]> Co-authored by: Anh Van <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes 2605. This shall enable targets under the cFS build tree to find CMake target exported from outside of the cFS build tree
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Should be backward compatible. Not foreseeing issues
System(s) tested on
Additional context
Can provide with example repository where I this feature is usefull
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Maxime Haselbauer (Personal)