Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2597, fix sb coverage test failure #2602

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Sep 16, 2024

Fix #2597, fix sb coverage test failure involving topic ID

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.

Fix #2597, fix sb coverage test failure involving topic ID. Resolved issue with SB coverage test failure when topic ID is not used.

Testing performed
Steps taken to test the contribution:

  1. Ran against DAVINCI code's
  2. Ran against Opensource

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLAs apply to only software contributions.

Anh Van, GSFC

Fix nasa#2597, fix sb coverage test failure involving topic ID
@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Oct 3, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Maxime Haselbauer <[email protected]>
Co-authored by: Anh Van <[email protected]>
@dzbaker dzbaker merged commit fa4088c into nasa:main Oct 3, 2024
21 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Maxime Haselbauer <[email protected]>
Co-authored by: Anh Van <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 5, 2024
*Combines:*

cFE equuleus-rc1+dev209
osal equuleus-rc1+dev89
cFS-GroundSystem equuleus-rc1+dev6

**Includes:**

*cFE*
- nasa/cFE#2602

*osal*
- nasa/osal#1416

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#246

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Dylan Baker <[email protected]>
@dzbaker dzbaker mentioned this pull request Nov 5, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 5, 2024
*Combines:*

cFE equuleus-rc1+dev209
osal equuleus-rc1+dev89
cFS-GroundSystem equuleus-rc1+dev6

**Includes:**

*cFE*
- nasa/cFE#2602

*osal*
- nasa/osal#1416

*cFS-GroundSystem*
- nasa/cFS-GroundSystem#246

Co-authored by: Avi Weiss <[email protected]>
Co-authored by: Dylan Baker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOPIC ID - SB Coverage Test Failure
3 participants