Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1360, Limit HK Commands to 1 in pipe + replace hand-written function names with __func__ #2498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes Limit send HK MID's to 1 in pipe #1360
    • Limits Send HK MIDs in the ES command pipe to 1 at a time using CFE_SB_SubscribeEx()
    • Also piggy-backing on this PR are a few typo fixes, updates to out-of-date identifiers, and replacing hand-written function names with __func__ (to reduce chances of these coming out of sync in the future)

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
Send HK MIDs in ES command pipe will be explicitly limited to 1 at a time instead of whatever the default is set to (currently 4).

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1360-limit-cfe-es-hk-commands-to-1-in-pipe branch from cb7f988 to ef8b25c Compare April 20, 2024 06:12
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment/syslog cleanup is a good change, no issue there. But the pipe depth change might entail more review. I do think it makes sense for a SEND_HK request to be limited at 1 though, so I think this is worth discussion.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 23, 2024
@skliper
Copy link
Contributor

skliper commented May 23, 2024

Changing to one was a code review suggestion. If there's more than one something is probably broken or at least extremely delayed and worth notifying the user (via the event from SB on msg limited). I can't imagine a use case for having more than one in the pipe, but maybe I'm not imaginative enough?

@thnkslprpt thnkslprpt force-pushed the fix-1360-limit-cfe-es-hk-commands-to-1-in-pipe branch from ef8b25c to c241dfe Compare July 9, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Ready Ready for discussion at the Configuration Control Board (CCB)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit send HK MID's to 1 in pipe
3 participants