Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit send HK MID's to 1 in pipe #1360

Open
skliper opened this issue Apr 14, 2021 · 2 comments · May be fixed by #2498
Open

Limit send HK MID's to 1 in pipe #1360

skliper opened this issue Apr 14, 2021 · 2 comments · May be fixed by #2498
Labels
CFS-40 enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 14, 2021

Is your feature request related to a problem? Please describe.
Default limit of 4 is excessive, getting behind is an error (shouldn't spam them either way).

ES example:

cFE/modules/es/fsw/src/cfe_es_task.c

Line 405 in e80aae9

Status = CFE_SB_Subscribe(CFE_SB_ValueToMsgId(CFE_ES_SEND_HK_MID), CFE_ES_Global.TaskData.CmdPipe);

Describe the solution you'd like
Set to 1

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper modified the milestone: 7.0.0 Apr 14, 2021
@thnkslprpt
Copy link
Contributor

@skliper you mean like this?

Status = CFE_SB_SubscribeEx(CFE_SB_ValueToMsgId(CFE_ES_SEND_HK_MID), CFE_ES_Global.TaskData.CmdPipe, CFE_SB_DEFAULT_QOS, 1);

@skliper
Copy link
Contributor Author

skliper commented Jan 16, 2024

Yes, that looks right.

thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jan 17, 2024
@thnkslprpt
Fix nasa#1360, Limit HK Commands to 1 in pipe at a time
fdff57a
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jan 17, 2024
@thnkslprpt
Fix nasa#1360, Limit HK Commands to 1 in pipe at a time
cb7f988
@thnkslprpt thnkslprpt linked a pull request Jan 17, 2024 that will close this issue
Open
2 tasks
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Apr 20, 2024
@thnkslprpt
Fix nasa#1360, Limit HK Commands to 1 in pipe at a time
ef8b25c
thnkslprpt added a commit to thnkslprpt/cFE that referenced this issue Jul 9, 2024
@thnkslprpt
Fix nasa#1360, Limit HK Commands to 1 in pipe at a time
c241dfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CFS-40 enhancement
Projects
None yet
Milestone
No milestone
2 participants
@thnkslprpt @skliper