Fix #2395, do not directly use cfe_test_msgids.h #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a user that has customized cfe_msgids.h, this will get conflicting values. If/when users have migrated to module-specific msgid files, this will be OK, but for now this can break things.
jphickey
added
CCB:Ready
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 17, 2023
Fast-Tracked cFE Pull Request nasa/cFE#2398, nasa/cFE#2399, nasa/cFE#2404: Resolves nasa/cFE#2393, nasa/cFE#2395. Reverts nasa/cFE#2399
dzbaker
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
For a user that has customized cfe_msgids.h, this will get conflicting values. If/when users have migrated to module-specific msgid files, this will be OK, but for now this can break things.
Fixes #2395
Testing performed
Build using override of
cfe_msgids.h(only).Expected behavior changes
No conflicting msgids if user has overridden
cfe_msgids.hbut notcfe_test_msgids.hSystem(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.