Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE TIME coverage test fails if set to use UTC #2393

Closed
jphickey opened this issue Jul 13, 2023 · 0 comments · Fixed by #2398 or nasa/cFS#686
Closed

CFE TIME coverage test fails if set to use UTC #2393

jphickey opened this issue Jul 13, 2023 · 0 comments · Fixed by #2398 or nasa/cFS#686
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
When configuration is set to use UTC, the "ExternalTone" test case will fail.

To Reproduce
Configure CFE_MISSION_TIME_CFG_DEFAULT_UTC to be true, then compile and run coverage tests.

Expected behavior
The test should pass regardless of how this configuration item is set.

System observed on:
Debian

Additional context
This is because it adds leap seconds into the NewSTCF value only when set to use UTC. The leap seconds were not configured by this test case, so it still has a value from a previous test case, which is 32. This larger-than-expected jump causes it to go into the CFE_TIME_OUT_OF_RANGE result case.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jul 13, 2023
jphickey added a commit that referenced this issue Jul 13, 2023
Setting this value to 0 allows it to get the same result regardless of
the setting of CFE_MISSION_TIME_CFG_DEFAULT_UTC.
jphickey added a commit that referenced this issue Jul 14, 2023
Setting this value to 0 allows it to get the same result regardless of
the setting of CFE_MISSION_TIME_CFG_DEFAULT_UTC.
dzbaker added a commit that referenced this issue Jul 17, 2023
Fix #2393, set AtLeapSeconds in ExternalTone test case
dzbaker added a commit to nasa/cFS that referenced this issue Jul 17, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment