Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2131, Increase event burst credit to not squelch at startup in CI #2132

Closed
wants to merge 1 commit into from

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Aug 8, 2022

Checklist (Please check before submitting)

Describe the contribution

Doubled the event squelch credit (16 to 32) to avoid ES event squelching at startup seen in app CI runs

Testing performed
Tested with 10 GSFC apps, no squelch observed

Expected behavior changes
Just increased the default credit, can burst up to 32 events before squelch.

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 8, 2022
@skliper skliper added this to the Draco milestone Aug 8, 2022
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 10, 2022
dzbaker added a commit that referenced this pull request Aug 10, 2022
Fix #2131, Increase event burst credit to not squelch at startup in CI
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 10, 2022
cfe v7.0.0-rc4+dev163

**Includes:**

- nasa/cFE#2132, Increase event burst credit to not squelch at startup in CI
- nasa/cFE#2134, Grammatical/format updates to EVS flooding requirements

Co-authored by: Jacob Hageman  <[email protected]>
@dzbaker dzbaker mentioned this pull request Aug 10, 2022
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Aug 10, 2022
*Combines:*

cfe v7.0.0-rc4+dev163

**Includes:**

- nasa/cFE#2132, Increase event burst credit to not squelch at startup in CI
- nasa/cFE#2134, Grammatical/format updates to EVS flooding requirements

Co-authored by: Jacob Hageman  <[email protected]>
@skliper skliper deleted the fix2131-increase_event_credit branch September 1, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event squelch triggering at startup on ES version reporting in submodule CI
2 participants