Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1997, Mismatched foreach in cmake function #2012

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix #1997, Mismatched foreach in cmake function #2012

merged 1 commit into from
Jan 21, 2022

Conversation

paulober
Copy link
Contributor

Describe the contribution

Additional context
-> conversation at #1997

Contributor Info - All information REQUIRED for consideration of pull request
Personal

@skliper
Copy link
Contributor

skliper commented Nov 1, 2021

Recommendation is to remove the arguments.

@paulober
Copy link
Contributor Author

paulober commented Nov 3, 2021

I know, I mentioned it in the issue but no response... I'll fix this in my PR.

@astrogeco
Copy link
Contributor

I know, I mentioned it in the issue but no response... I'll fix this in my PR.

thanks! We typically are a bit more responsive on PRs though this month has been hectic so our response time has been slower than usual. We appreciate your help!

@paulober paulober force-pushed the fix-1997-mismatched-foreach-in-cmake-func branch from c30da56 to b4d2ca8 Compare November 3, 2021 21:38
@paulober paulober force-pushed the fix-1997-mismatched-foreach-in-cmake-func branch from b4d2ca8 to 0521523 Compare November 3, 2021 21:43
@paulober
Copy link
Contributor Author

paulober commented Nov 3, 2021

I know, I mentioned it in the issue but no response... I'll fix this in my PR.

thanks! We typically are a bit more responsive on PRs though this month has been hectic so our response time has been slower than usual. We appreciate your help!

Ok, no problem. I'm grateful to be able to work on this project.

@paulober paulober marked this pull request as ready for review November 3, 2021 21:54
@astrogeco astrogeco added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Dec 7, 2021
@astrogeco
Copy link
Contributor

CCB:2021-12-08 - APPROVED

@astrogeco astrogeco mentioned this pull request Dec 15, 2021
Merged
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 19, 2022
@astrogeco
IC:Caelum+dev2, cFE Updates
b97efd0 
*cFE*

nasa/cFE#2015, Add FS Functional test
nasa/cFE#2012, Fix mismatched foreach in cmake function
nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide
nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var
nasa/cFE#2031, Fix array length calculation for perf structs
nasa/cFE#2023, Limit SBR UT loops
nasa/cFE#2029, Initialize BlockData in ES UT
nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c
@astrogeco astrogeco mentioned this pull request Jan 19, 2022
Merged
2 tasks
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 20, 2022
@astrogeco
IC:Caelum+dev2, cFE Updates
18aaa82 
*cFE*

nasa/cFE#2011, Reuse CodeQL, Static Analysis, and Format Check
nasa/cFE#2015, Add FS Functional test
nasa/cFE#2012, Fix mismatched foreach in cmake function
nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide
nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var
nasa/cFE#2031, Fix array length calculation for perf structs
nasa/cFE#2023, Limit SBR UT loops
nasa/cFE#2029, Initialize BlockData in ES UT
nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c
@astrogeco astrogeco merged commit efa4640 into nasa:main Jan 21, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 21, 2022
@astrogeco @ArielSAdamsNASA
@skliper @jphickey @kurtjd @paulober @Nodraak
IC:Caelum+dev2
d4a6e3f 
Combines:

nasa/cFE#2019, cFE v7.0.0-rc4+dev60
nasa/osal#1212, osal v6.0.0-rc4+dev29
nasa/sch_lab#105, sch_lab v2.5.0-rc4+dev13

Includes:

*cFE*

nasa/cFE#2033, Add CFE_ES_AppInfo_t element documentation
nasa/cFE#2011, Reuse CodeQL, Static Analysis, and Format Check
nasa/cFE#2015, Add FS Functional test
nasa/cFE#2012, Fix mismatched foreach in cmake function
nasa/cFE#2013, Improved code highlighting in cFE Application Developers Guide
nasa/cFE#2027, CFE_FS_ParseInputFileNameEx avoid uninit var
nasa/cFE#2031, Fix array length calculation for perf structs
nasa/cFE#2023, Limit SBR UT loops
nasa/cFE#2029, Initialize BlockData in ES UT
nasa/cFE#2025, Fix osal_id_t type conversion in es_UT.c

*osal*

nasa/osal#1206, Search global and local symbol tables
nasa/osal#1201, Add missing space to UtAssert_STUB_COUNT
nasa/osal#1202, Add UINT8 and UINT16 equivalents for UtAssert_UINT32_<Comparison> macros
nasa/osal#1203, correct warnings on gcc11
nasa/osal#1211, Set output in OS_stat handler
nasa/osal#1190, Reuse CodeQL, Static Analysis, Format Check

*other*

nasa/sch_lab#104, Add option to configure base tick rate

*Continuous Integration Updates*

nasa/PSP#317, Reuse CodeQL, Static Analysis, and Format Check

nasa/sample_lib#72, Reuse CodeQL, Static Analysis, and Format Check
nasa/sample_app#162, Reuse CodeQL, Static Analysis, and Format Check
nasa/ci_lab#100, Reuse CodeQL, Static Analysis, and Format Check
nasa/to_lab#111, Reuse CodeQL, Static Analysis, and Format Check

nasa/tblCRCTool#59, Reuse CodeQL, Static Analysis, and Format Check
nasa/elf2cfetbl#97, Reuse CodeQL, Static Analysis, and Format Check
nasa/cFS-GroundSystem#200, Reuse CodeQL, Static Analysis, and Format Check

Co-authored-by: Ariel Adams     <[email protected]>
Co-authored-by: Jacob Hageman   <[email protected]>
Co-authored-by: Joseph Hickey   <[email protected]>
Co-authored-by: Kurtis Dinelle  <[email protected]>
Co-authored-by: Paul            <[email protected]>
Co-authored-by: Adrien Chardon  <[email protected]>
@skliper skliper added this to the Draco milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc1
Projects
None yet
Milestone
Draco
Development

Successfully merging this pull request may close these issues.

Mismatched foreach in cmake function
3 participants
@paulober @skliper @astrogeco