Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate all CFE_OS error codes #580

Closed
skliper opened this issue Apr 2, 2020 · 1 comment · Fixed by #582 or #635
Closed

Deprecate all CFE_OS error codes #580

skliper opened this issue Apr 2, 2020 · 1 comment · Fixed by #582 or #635
Assignees
@skliper
Labels
deprecate
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Apr 2, 2020

Is your feature request related to a problem? Please describe.
See discussion on #552, CFE_OS error codes are an unnecessary abstraction. No plan to translate between the two, so no need to abstract.

Describe the solution you'd like
Deprecate and just use the OSAL error codes directly.

Describe alternatives you've considered
See discussion in #552

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper mentioned this issue Apr 2, 2020
Closed
@skliper skliper self-assigned this Apr 2, 2020
skliper added a commit to skliper/cFE that referenced this issue Apr 2, 2020
@skliper
Fix nasa#580, Deprecate CFE_OS_ abstracted error codes
35161c6 
Added CFE_OMIT_DEPRECATED_6_7 just to be consistant
Also fix nasa#522 - removes non-existant codes
skliper added a commit to skliper/cFE that referenced this issue Apr 2, 2020
@skliper
Fix nasa#580, Deprecate CFE_OS_ abstracted error codes
48391b5 
Added CFE_OMIT_DEPRECATED_6_7 just to be consistent
Also fix nasa#522 - removes non-existent codes
@skliper skliper mentioned this issue Apr 2, 2020
Merged
skliper added a commit to skliper/cFE that referenced this issue Apr 2, 2020
@skliper
Fix nasa#580, Deprecate CFE_OS_ abstracted error codes
fe700b7 
Added CFE_OMIT_DEPRECATED_6_7 just to be consistent
Also fix nasa#552 - removes non-existent codes
@skliper skliper added this to the 6.8.0 milestone Apr 3, 2020
@ejtimmon
Copy link
Contributor

FM uses CFE_OS_ERROR.

astrogeco added a commit that referenced this issue Apr 21, 2020
@astrogeco
Merge pull request #582 from skliper/fix580-deprecate-cfe-os-error-codes
9f7de0f 
Fix #580, Deprecate CFE_OS_ abstracted error codes
@astrogeco astrogeco mentioned this issue Apr 27, 2020
Merged
@astrogeco astrogeco linked a pull request Apr 27, 2020 that will close this issue
Integration Candidate: 2020-04-15 #635
Merged
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue May 12, 2020
@CDKnightNASA
missed a MID wrap, other fixes related to ticket nasa#666, nasa#523, n…
070af1e 
…asa#580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
deprecate
Projects
None yet
Milestone
Bootes
3 participants
@ejtimmon @skliper @astrogeco