Remove undefined error defines in cfe_error.h

[skliper]

Is your feature request related to a problem? Please describe.

cFE/fsw/cfe-core/src/inc/cfe_error.h

Lines 757 to 763 in f1be048

	#define CFE_OS_ERROR_TASK_ID (OS_ERROR_TASK_ID)
	/**
	**
	**
	*/
	#define CFE_OS_SEM_UNAVAILABLE (OS_SEM_UNAVAILABLE)

neither of these exist in OSAL

Describe the solution you'd like
Delete

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

[jphickey]

Actually, I would propose removing all of the CFE_OS_ error codes. They only occur in one place in the unit test and that place is wrong (should be using the OSAL-provided constant).

There should be no need for these duplicate names for the same error codes. It would be a different story if they were providing some abstraction, but they are not- they are only providing a different name for the same thing.

[skliper]

Yeah, I thought this topic had been touched on recently but I didn't find an issue (maybe in comments somewhere?) I'd be interested to hear from @acudmore.

[jphickey]

It came up in the review of a recent change (issue #308/pull #452) where it was initially mixing the OS_ERR_ codes (direct from osal) and these CFE_OS_ synonyms. That changeset was subsequently modified to use only the OSAL error codes.

Logically speaking - If calling an OSAL function directly, it should be comparing to the OSAL error codes directly too.

The gray area comes in when CFE API calls in turn call the OSAL API, and return the OSAL error directly. For true abstraction this is a bad paradigm and shouldn't even be done (it should explicitly translate the code). But for efficiency the CFE error codes are simply chosen to not overlap/alias OSAL codes to make this practice OK, and it is understood that a return code from a CFE API might be either an OSAL error code or a CFE error code. Since both sets agree on the general pattern that negative is error and non-negative is success, its fine.

At any rate, cfe_error.h internally also includes osapi.h so if an application does a #include <cfe_error.h> then this will provide the OSAL error codes too.

So long as we aren't explicitly translating OSAL error codes to CFE error codes, we do not need to redefine the OSAL error constants in CFE either (and should not) .

[skliper]

Bigger issue probably worth 2 steps - deprecate then remove, the undefined referenced here could just be removed (they'd likely already be broken).

[skliper]

See #580 to cover deprecation of the entire set.