Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_ResourceId_FindNext can Seg Fault #1840

Closed
zanzaben opened this issue Aug 18, 2021 · 0 comments · Fixed by #1842 or #1839
Closed

CFE_ResourceId_FindNext can Seg Fault #1840

zanzaben opened this issue Aug 18, 2021 · 0 comments · Fixed by #1842 or #1839
Labels
enhancement
Milestone
Caelum

Comments

@zanzaben
Copy link
Contributor

zanzaben commented Aug 18, 2021 •
edited
Loading

Describe the bug
If you pass a null for the CheckFunc argument then CFE_ResourceId_FindNext will Segmentation Fault. Also the Comments in the c file mention how it is an internal function which it currently isn't.

Expected behavior
There should be a null check.
A Functional Test for that null check.
Update the header file for the new return code

Additional context
new functional test should plan with #1782

Reporter Info
Alex Campbell GSFC
@skliper skliper added this to the 7.0.0 milestone Aug 18, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 18, 2021
@zanzaben
Fix nasa#1840, Add Null check for CFE_ResourceId_FindNext
c25c8e5
@zanzaben zanzaben mentioned this issue Aug 18, 2021
Merged
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 18, 2021
@zanzaben
Fix nasa#1840, Add Null check for CFE_ResourceId_FindNext
aa72f85
astrogeco added a commit that referenced this issue Aug 18, 2021
@astrogeco
Merge pull request #1842 from zanzaben/fix1840_ResourceID_FindNext_nu…
b8df511 
…ll_check

Fix #1840, Add Null check for CFE_ResourceId_FindNext
@astrogeco astrogeco mentioned this issue Aug 18, 2021
Merged
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 18, 2021
@zanzaben
Fix nasa#1840, Hotfix for strict resource IDs.
e879296
@zanzaben zanzaben mentioned this issue Aug 18, 2021
Merged
astrogeco added a commit that referenced this issue Aug 18, 2021
@astrogeco
Merge pull request #1844 from zanzaben/fix1840_ResourceID_FindNext_nu…
41b0ea2 
…ll_check

Fix #1840, Hotfix for strict resource IDs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @skliper