You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe. CFE_SB_GetAppTskName(TskId, FullName) is called in virtually every API event message, example:
"CreatePipeErr:OS_QueueCreate returned %d,app %s", (int)Status,
CFE_SB_GetAppTskName(TskId, FullName));
Note for the special case in CFE_SB_DeletePipeFull it currently overloads FullName with caller and owner. Really should report both if there isn't a match. Also FullName is referenced before initialized below, but not used...:
Describe the solution you'd like
Construct FullName outside switch and use it.
Describe alternatives you've considered
Really there's inconsistent reporting in APIs (sometimes system log, sometimes events, unique message formats all over with differing info), would benefit from an overhaul. See also #1403 and related issues (#994, etc) to fix.
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
CFE_SB_GetAppTskName(TskId, FullName)
is called in virtually every API event message, example:cFE/modules/sb/fsw/src/cfe_sb_api.c
Lines 235 to 260 in c8b5e00
Note for the special case in
CFE_SB_DeletePipeFull
it currently overloads FullName with caller and owner. Really should report both if there isn't a match. Also FullName is referenced before initialized below, but not used...:cFE/modules/sb/fsw/src/cfe_sb_api.c
Line 378 in c8b5e00
Describe the solution you'd like
Construct FullName outside switch and use it.
Describe alternatives you've considered
Really there's inconsistent reporting in APIs (sometimes system log, sometimes events, unique message formats all over with differing info), would benefit from an overhaul. See also #1403 and related issues (#994, etc) to fix.
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: