Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE_EVS_SendEventWithAppID design improvements wrt EID context and calling context #1403

Open
skliper opened this issue Apr 21, 2021 · 1 comment

Comments

@skliper
Copy link
Contributor

skliper commented Apr 21, 2021

Is your feature request related to a problem? Please describe.
CFE_EVS_SendEventWithAppID is really intended to provide the EID context when an event is created from a library. Unfortunately the EID context replaces the app context info (name), which means for short events the ground does not have app context (can't tell what app generated the event). Also means filtering by app context isn't possible for these types of events, and apps really have no insight into or control over these events.

Describe the solution you'd like
Consider options to include both EID context and app context in short messages, filtering, etc. Could utilize extra bits, could add a field, etc. May even help to rename CFE_EVS_SendEventWithAppID to something that indicates overriding the EID context. Note if special bits were just reserved, this may collapse down to one API again (CFE_EVS_SendEvent), but depends on how the rest is addressed.

Describe alternatives you've considered
See above.

Additional context
Spawned from code review follow-up. Related to #1388 and #1389.

Requester Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Apr 29, 2021

Note there's inconsistent use of CFE_EVS_SendEventWithAppID vs CFE_ES_WriteToSysLog based on service. SB and TBL APIs mostly use the former, the rest the later. SB has an internal function to include the FullName in the event message which includes calling context app and task name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant