Integration Candidate 2020-10-13 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the osal_id_t typedef whenever dealing with an OSAL ID value.
Resolves build error regarding redefinition of PPC macros in the coverage test, when building on the actual ppc/vxworks target. This is due to the fact that the system limits.h file implicitly provides these PPC symbols. It does not appear that there are any current test cases that depend on values of these symbols.
Fix #200, Update PSP to use osal_id_t
Fix #204, redefinition of macros in PPC vxworks unit test build
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #200
Fix #204
Testing performed
See Bundle PR - https://github.com/nasa/cFS/pull/147/checks
Expected behavior changes
PR #201 - Use the osal_id_t typedef whenever dealing with an OSAL ID value.
PR #205 - Resolves build error regarding redefinition of PPC macros in the coverage test, when building on the actual ppc/vxworks target.
System(s) tested on
Bundle CI, Ubuntu
Additional context
Part of nasa/cFS#147
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey