Fix #204, redefinition of macros in PPC vxworks unit test build #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves build error regarding redefinition of PPC macros in the coverage test, when building on the actual ppc/vxworks target. This is due to the fact that the system limits.h file implicitly provides these PPC symbols. It does not appear that there are any current test cases that depend on values of these symbols.
jphickey
added
the
CCB:Ready
astrogeco
added
CCB-20201006
and removed
CCB:Ready
|
CCB 2020-10-06 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #204
Resolves build error regarding redefinition of PPC macros in the coverage test, when building on the actual ppc/vxworks target.
This is due to the fact that the system limits.h file implicitly provides these PPC symbols. It does not appear that there are
any current test cases that depend on values of these symbols.
Testing performed
Build verification only at this time (resolves compile error)
Expected behavior changes
None
System(s) tested on
GSFC vxworks build machine (gs582w-cfelnx)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.