Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #77: Revert merge of PR #52. #78

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix #77: Revert merge of PR #52. #78

merged 1 commit into from
Jul 6, 2023

Conversation

dzbaker
Copy link
Contributor

@dzbaker dzbaker commented Jul 6, 2023

Checklist (Please check before submitting)

Describe the contribution
Fixes #77.

Expected behavior changes
Reverts #52.

Contributor Info - All information REQUIRED for consideration of pull request
Dylan Z. Baker - NASA/GSFC

This reverts commit df7401f, reversing
changes made to da7ef70.
@dzbaker dzbaker merged commit 9535a04 into main Jul 6, 2023
29 of 30 checks passed
@skliper
Copy link
Contributor

skliper commented Jul 6, 2023

@dzbaker @dmknutsen - consider reopening the related issue when reverting. Or mark the issue so it doesn't get mixed in with issues that were actually addressed/resolved, and could be reopened in the future if someone requests it again. I think there was another PR recently that got reverted where the issue could also be updated?

My concern is if you look at #8 - it doesn't show anywhere the associated PR got reverted, so isn't actually resolved.

dzbaker added a commit to dzbaker/MM that referenced this pull request Jul 11, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert PR #52
3 participants