Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM_DumpInEventCmd wastes event characters #8

Open
skliper opened this issue Apr 22, 2022 · 2 comments · Fixed by #52 · May be fixed by #79
Open

MM_DumpInEventCmd wastes event characters #8

skliper opened this issue Apr 22, 2022 · 2 comments · Fixed by #52 · May be fixed by #79
Labels
enhancement

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

In MM_DumpInEventCmd, including the "0x" and trailing space on the hex digits unnecessarily limits how much can actually be dumped in the event.

Imported from GSFCCFS-1564
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue Oct 23, 2022
@thnkslprpt
Fix nasa#8, Remove unnecessary characters from memory dump event
a89c2cf
@thnkslprpt thnkslprpt mentioned this issue Oct 23, 2022
Merged
2 tasks
@thnkslprpt
Copy link
Contributor

I had a go at this but the unit tests don't seem to test what has been changed exactly.
Is there a way that the memory dump can be tested directly?

thnkslprpt added a commit to thnkslprpt/MM that referenced this issue Mar 12, 2023
@thnkslprpt
Fix nasa#8, Remove unnecessary characters from memory dump event
d96f62b
thnkslprpt added a commit to thnkslprpt/MM that referenced this issue Mar 14, 2023
@thnkslprpt
Fix nasa#8, Remove unnecessary characters from memory dump event
3746982
dzbaker added a commit that referenced this issue May 25, 2023
@dzbaker
Merge pull request #52 from thnkslprpt/fix-8-remove-unnecessary-chara…
df7401f 
…cters-in-dump-event

Fix #8, Remove unnecessary characters from memory dump event
@skliper skliper mentioned this issue Jul 6, 2023
Merged
2 tasks
@dzbaker
Copy link
Contributor

dzbaker commented Jul 11, 2023

Issue is being re-opened to address in Equuleus-rc2.

@dzbaker dzbaker reopened this Jul 11, 2023
dzbaker added a commit to dzbaker/MM that referenced this issue Jul 11, 2023
@dzbaker
Fix nasa#8, Re-introduce change from PR nasa#78.
6c1be31
dzbaker added a commit to dzbaker/MM that referenced this issue Jul 11, 2023
@dzbaker
Fix nasa#8, Re-introduce change from PR nasa#52.
1127014
@dzbaker dzbaker linked a pull request Jul 11, 2023 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@dzbaker @thnkslprpt @skliper