Fix #37, Sends message when file complete #39
Conversation
|
@skliper Do I manually implement the stub function in apps/ds/unit-test/stubs in this pull request? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chillfig
force-pushed
the
send_msg
branch
2 times, most recently
from
b6b6fc2
to
12d30a4
Compare
There was a problem hiding this comment.
Great start! See comments. Since the new function is only called from ds_file.c it doesn't seem like you need to implement a stub. Just add a unit test within the ds_file_tests.c. Should also consider adding a requirement and updating the design slides, although the design slides aren't configuration managed within the repo anymore so we'll need to establish a new process.
chillfig
force-pushed
the
send_msg
branch
4 times, most recently
from
8a78e3c
to
a269a84
Compare
| /* | ||
| ** Get the directory name... | ||
| */ | ||
| strncpy(FileStatus->FileName, PathName, sizeof(PathName)); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
chillfig
force-pushed
the
send_msg
branch
5 times, most recently
from
3d3a084
to
49ebb24
Compare
chillfig
force-pushed
the
send_msg
branch
7 times, most recently
from
26573f2
to
5c1b8b9
Compare
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
|
|
||
| void DS_FileTransmit(DS_AppFileStatus_t *FileStatus) |
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
chillfig
changed the title
chillfig
changed the title
chillfig
changed the title
| */ | ||
| if (PktBuf != NULL) | ||
| { | ||
| CFE_MSG_Init(&PktBuf->Pkt.TlmHeader.Msg, CFE_SB_ValueToMsgId(DS_COMP_TLM_MID), sizeof(*PktBuf)); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| /* | ||
| ** Set current open filename... | ||
| */ | ||
| strcpy(PktBuf->Pkt.FileInfo.FileName, FileStatus->FileName); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| ** Timestamp and send file info telemetry... | ||
| */ | ||
| CFE_SB_TimeStampMsg(&PktBuf->Pkt.TlmHeader.Msg); | ||
| CFE_SB_TransmitBuffer(&PktBuf->SBBuf, true); |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked return value
| /* | ||
| ** Set file age and size... | ||
| */ | ||
| PktBuf->Pkt.FileInfo.FileAge = FileStatus->FileAge; |
Check warning
Code scanning / CodeQL-coding-standard
Unchecked function argument
chillfig
force-pushed
the
send_msg
branch
4 times, most recently
from
79a445a
to
32c0895
Compare
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test, Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference, Adds logic to extract data from FileStatus, Adds copy of Move Directory, Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED, Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer, Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer, Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction, Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv, Update software buffer use to work correctly, Corrects whitespace in csv, Adds buffer to unit test, Adds comment changes for doxygen and readability, Changes \sa references in comment header of DS_FileTransmit(), Adds DS_FileCompletePktBuf_t element comments
| * that compiles with the alignment constraints of a CFE_SB_Buffer_t | ||
| */ | ||
| typedef union | ||
| { |
Check notice
Code scanning / CodeQL-coding-standard
AV Rule 153
|
@dzbaker I think this is ready to merge. |
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
Generate a message when a file gets completed.
System(s) tested on
Additional context
None
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal