We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist (Please check before submitting)
Describe the bug Pathname is only set when move is not empty, but the copy is done outside that condition:
DS/fsw/src/ds_file.c
Lines 891 to 906 in 733b2b2
Line 968 in 733b2b2
To Reproduce Produce the packet with move empty
Expected behavior Only copy over if Pathname was set
System observed on: Observed, also flagged by static analysis
Additional context Introduced with file complete tlm packet updates - #39, so doesn't impact draco-rc2
Reporter Info Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
e6f9682
Merge pull request #47 from skliper/fix46-strcpy_overflows
96e2021
Fix #46 #48 #49 #50, Resolve multiple static analysis issues (includes bug fixes) and remove unnecessary UT handlers
skliper
Successfully merging a pull request may close this issue.
Checklist (Please check before submitting)
Describe the bug
Pathname is only set when move is not empty, but the copy is done outside that condition:
DS/fsw/src/ds_file.c
Lines 891 to 906 in 733b2b2
DS/fsw/src/ds_file.c
Line 968 in 733b2b2
To Reproduce
Produce the packet with move empty
Expected behavior
Only copy over if Pathname was set
System observed on:
Observed, also flagged by static analysis
Additional context
Introduced with file complete tlm packet updates - #39, so doesn't impact draco-rc2
Reporter Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: