Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a message when new files are completed #37

Closed
3 tasks done
chillfig opened this issue Jul 12, 2022 · 0 comments · Fixed by #39
Closed
3 tasks done

Send a message when new files are completed #37

chillfig opened this issue Jul 12, 2022 · 0 comments · Fixed by #39
Assignees
@chillfig
Labels
draco-rc3 enhancement
Milestone
Draco

Comments

@chillfig
Copy link
Contributor

chillfig commented Jul 12, 2022 •
edited
Loading

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Send a message when new files are completed in DS.

Describe the solution you'd like

  • Initialize and send a message using CFE_MSG_INIT() and CFS_SB_TransmitMsg() respectively.
  • Define a new packet DS_FileCompletePkt_t for a single DS_FileInfo_t payload.
  • Define a new MsgID.
  • May need to include logic that will use "movename" when DS_MOVE_FILES == FALSE and use "filename" when DS_MOVES_FILES == TRUE.
  • This feature will be implemented at the close of a file within the FileCloseDest() function.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Justin Figueroa, ASRC Federal
@chillfig chillfig self-assigned this Jul 12, 2022
@skliper skliper added this to the Draco milestone Jul 14, 2022
chillfig added a commit to chillfig/DS that referenced this issue Jul 21, 2022
@chillfig
Fix nasa#37, Attempt to send message when file complete
effd2c7
@chillfig chillfig mentioned this issue Jul 21, 2022
Merged
2 tasks
chillfig added a commit to chillfig/DS that referenced this issue Jul 21, 2022
@chillfig
Fix nasa#37, Attempt to send message when file complete
7d6cc07 
Adds reference of DS_FileTransmit() within DS_FileCloseDest()
chillfig added a commit to chillfig/DS that referenced this issue Jul 21, 2022
@chillfig
Fix nasa#37, Attempt to send message when file complete
889589d 
Adds reference of DS_FileTransmit() within DS_FileCloseDest()
Adds forgotten semi-colon
chillfig added a commit to chillfig/DS that referenced this issue Jul 21, 2022
@chillfig
Fix nasa#37, Attempt to send message when file complete
b6b6fc2 
Adds reference of DS_FileTransmit() within DS_FileCloseDest()
Adds forgotten semi-colon, Changes function header comment
chillfig added a commit to chillfig/DS that referenced this issue Jul 21, 2022
@chillfig
Fix nasa#37, Attempt to send message when file complete
12d30a4 
Adds reference of DS_FileTransmit() within DS_FileCloseDest()
Adds forgotten semi-colon, Changes function header comment,
Adds msgid for complete file info, Changes struct header comment
chillfig added a commit to chillfig/DS that referenced this issue Jul 25, 2022
@chillfig
Fix nasa#37, Attempt to send message when file complete
ee82dd5 
Adds reference of DS_FileTransmit() within DS_FileCloseDest()
Adds forgotten semi-colon, Changes function header comment,
Adds msgid for complete file info, Changes struct header comment
chillfig added a commit to chillfig/DS that referenced this issue Jul 25, 2022
@chillfig
Fix nasa#37, Adds file transmit feature at file completion
19d1aeb 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test
chillfig added a commit to chillfig/DS that referenced this issue Jul 25, 2022
@chillfig
Fix nasa#37, Adds file transmit feature at file completion
8a78e3c 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces
chillfig added a commit to chillfig/DS that referenced this issue Jul 25, 2022
@chillfig
Fix nasa#37, Adds file transmit feature at file completion
a269a84 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference
chillfig added a commit to chillfig/DS that referenced this issue Jul 26, 2022
@chillfig
Fix nasa#37, Adds file transmit feature at file completion
7b7001d 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Adds file transmit feature at file completion
5540c2f 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Adds CFE_SB_TransmitBuffer to send message when file com…
84d7e6b 
…plete

Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Adds CFE_SB_TransmitBuffer to send message when file com…
fb0d40d 
…plete

Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Adds CFE_SB_TransmitBuffer to send message when file com…
6e4d0ca 
…plete

Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Adds CFE_SB_TransmitBuffer to send message when file com…
3d3a084 
…plete

Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Adds CFE_SB_TransmitBuffer to send message when file com…
49ebb24 
…plete

Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Adds CFE_SB_TransmitBuffer to send message when file com…
7c7a81f 
…plete

Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Sends message when file complete
37ff2b7 
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t
chillfig added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@chillfig
Fix nasa#37, Sends message when file complete
9a9ac41 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv
skliper added a commit to chillfig/DS that referenced this issue Jul 27, 2022
@skliper
Fix nasa#37, Update software buffer use to work correctly
2c53684
chillfig added a commit to chillfig/DS that referenced this issue Jul 28, 2022
@chillfig
Fix nasa#37, Sends message when file complete
0a5630a 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv
chillfig added a commit to chillfig/DS that referenced this issue Jul 28, 2022
@chillfig
Fix nasa#37, Sends message when file complete
199ed8e 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv
chillfig added a commit to chillfig/DS that referenced this issue Jul 28, 2022
@chillfig
Fix nasa#37, Send message with buffer provided
f8bb91f
chillfig added a commit to chillfig/DS that referenced this issue Jul 28, 2022
@chillfig
Fix nasa#37, Send message with buffer provided
3e789b4
chillfig added a commit to chillfig/DS that referenced this issue Jul 28, 2022
@chillfig
Fix nasa#37, Send message with buffer provided
26573f2
chillfig added a commit to chillfig/DS that referenced this issue Jul 28, 2022
@chillfig
Fix nasa#37, Send message with buffer provided
5c1b8b9
chillfig added a commit to chillfig/DS that referenced this issue Jul 28, 2022
@chillfig
Fix nasa#37, Sends message when file complete
39b122e 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv,
Adds buffer to unit test
chillfig added a commit to chillfig/DS that referenced this issue Aug 2, 2022
@chillfig
Fix nasa#37, Sends message when file complete
9c1be05 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv,
Adds buffer to unit test, Adds comment changes for doxygen and readability
chillfig added a commit to chillfig/DS that referenced this issue Aug 2, 2022
@chillfig
Fix nasa#37, Sends message when file complete
7702c39 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv,
Adds buffer to unit test, Adds comment changes for doxygen and readability
chillfig added a commit to chillfig/DS that referenced this issue Aug 2, 2022
@chillfig
Fix nasa#37, Sends message when file complete
79a445a 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv,
Adds buffer to unit test, Adds comment changes for doxygen and readability
chillfig added a commit to chillfig/DS that referenced this issue Aug 2, 2022
@chillfig
Fix nasa#37, Sends message when file complete
32c0895 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv,
Adds buffer to unit test, Adds comment changes for doxygen and readability,
Changes \sa references in comment header of DS_FileTransmit()
chillfig added a commit to chillfig/DS that referenced this issue Aug 2, 2022
@chillfig
Fix nasa#37, Sends message when file complete
edda450 
Adds FileStatus as the sole parameter to DS_FileTransmit(), Adds unit test,
Adds inclusion of ds_apps.h to ds_msg.h, Removes whitespaces, Adds dereference,
Adds logic to extract data from FileStatus, Adds copy of Move Directory,
Removes ds_apps.h inclusion, Sets OpenState to DS_CLOSED,
Adds unit test, Adds buffer struct, Adds CFE_SB_AllocateMessageBuffer
and CFE_SB_TransmitBuffer, Adds pointer cast in CFE_SB_AllocateMessageBuffer,
Adds CFE_SB_ValueToMsgId to CFE_MSG_Init, Adds & to CFE_SB_TransmitBuffer,
Adds pointer cast to CFE_SB_TransmitBuffer, Adds format correction,
Adds CFE_SB_Buffer_t to DS_FileCompletePkt_t, Adds requirement to csv,
Update software buffer use to work correctly, Corrects whitespace in csv,
Adds buffer to unit test, Adds comment changes for doxygen and readability,
Changes \sa references in comment header of DS_FileTransmit(),
Adds DS_FileCompletePktBuf_t element comments
dzbaker added a commit that referenced this issue Aug 3, 2022
@dzbaker
Merge pull request #39 from chillfig/send_msg
060607e 
Fix #37, Sends message when file complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillfig chillfig

Labels
draco-rc3 enhancement
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #37, Sends message when file complete chillfig/DS
3 participants
@skliper @dmknutsen @chillfig