Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-refactor-v1.0.1 #35

Merged
merged 18 commits into from
Dec 21, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if(CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)
enable_testing()
endif()

set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra") #-Werror
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Werror")

include_directories(include)

Expand Down
4 changes: 4 additions & 0 deletions src/src_main/crypto_tc.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ int32_t Crypto_TC_ApplySecurity(const uint8_t *p_in_frame, const uint16_t in_fra
printf("%02X", ((uint8_t *)&*p_in_frame)[i]);
}
printf("\nPrinted %d bytes\n", in_frame_length);
#else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also do: (void) in_frame_length;
This method is used in FreeRTOS a lot.

// TODO - Find another way to know this and remove this argument
uint16_t tmp = in_frame_length;
tmp = tmp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the purpose of this 'tmp' variable... Or the tmp = tmp statement.

#endif

if (crypto_config == NULL)
Expand Down
4 changes: 4 additions & 0 deletions util/core/shared_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ void debug_printf(const char *format, ...)
#else
void debug_printf(const char *format, ...)
{
format = format; // TODO - is this function / argument necessary?
// Do nothing, DEBUG preprocessor disabled.
}
#endif
Expand Down Expand Up @@ -141,6 +142,9 @@ void debug_hexprintf(const char *bin_data, int size_bin_data)
#else
void debug_hexprintf(const char *bin_data, int size_bin_data)
{
// TODO - is this function / argument necessary?
bin_data = bin_data;
size_bin_data = size_bin_data;
// Do nothing, DEBUG preprocessor disabled.
}
#endif