1-refactor-v1.0.1 #35
Conversation
…osing functions;
jlucas9
requested review from
szemerick,
IbraheemYSaleh,
rjbrown2 and
dccutrig
| @@ -68,6 +68,10 @@ int32_t Crypto_TC_ApplySecurity(const uint8_t *p_in_frame, const uint16_t in_fra | |||
| printf("%02X", ((uint8_t *)&*p_in_frame)[i]); | |||
| } | |||
| printf("\nPrinted %d bytes\n", in_frame_length); | |||
| #else | |||
There was a problem hiding this comment.
can also do: (void) in_frame_length;
This method is used in FreeRTOS a lot.
|
There're definitely some style clashes here that I don't fully agree with (EG, enforcing the 120 maximum characters per a single line rule, forcing even simple if blocks to span multiple lines, etc), but overall, this refactor does improve the code structure for CryptoLib 👍 ... The only real issue I have is that the MariaDB code is broken with the build (-DMYSQL=ON) ... I'll go ahead and start working on fixing that and push the commits to this branch. |
| sa->akid = atoi(row[i]); | ||
| continue; | ||
| } | ||
| if (strcmp(field_names[i], "sa_state") == 0) |
There was a problem hiding this comment.
Just a comment (no code changes expected here), I've always been under the impression that code readability trumps style consistency. Having these blocks tightly packed on ~30 single, easy to read lines was, in my opinion, infinitely more readable/valuable than having them spread over these 150+ lines.
| #else | ||
| // TODO - Find another way to know this and remove this argument | ||
| uint16_t tmp = in_frame_length; | ||
| tmp = tmp; |
There was a problem hiding this comment.
I don't see the purpose of this 'tmp' variable... Or the tmp = tmp statement.
I did touch every single file, but ensured that all existing tests passed at each step along the way.
Really just a lot of reformatting with the last two commits being the largest and potentially controversial as it exposes additional functionality to user space in favor of smaller files.
Let me know what you think - if you'd rather not have one of these changes or if something was missed!
Thanks in advance.