Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/cryptolib#249] Fixed custom path cmake variable usage #250

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

williamposey
Copy link
Contributor

Fixed custom path cmake variable usage in CMakeLists.txt and src/CMakeLists.txt

@williamposey williamposey linked an issue Jun 4, 2024 that may be closed by this pull request
@williamposey williamposey changed the base branch from main to dev June 4, 2024 11:08
@williamposey williamposey added the cmp NASA GSFC CMP label Jun 4, 2024
@williamposey williamposey requested a review from jlucas9 June 4, 2024 11:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.91%. Comparing base (277a3fd) to head (9db3e54).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #250   +/-   ##
=======================================
  Coverage   73.91%   73.91%           
=======================================
  Files           8        8           
  Lines        2914     2914           
  Branches      461      461           
=======================================
  Hits         2154     2154           
  Misses        588      588           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@williamposey williamposey changed the title #249 Fixed custom path cmake variable usage [nasa/cryptolib#249] Fixed custom path cmake variable usage Jun 4, 2024
@jlucas9 jlucas9 requested a review from Donnie-Ice June 4, 2024 11:53
Copy link
Collaborator

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after 2+ approvals!

@rjbrown2 rjbrown2 merged commit de73865 into dev Jun 4, 2024
5 checks passed
@jlucas9 jlucas9 deleted the 249-fix-custom-module-paths branch August 1, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp NASA GSFC CMP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix custom module paths
4 participants