Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom module paths #249

Closed
williamposey opened this issue Jun 4, 2024 · 0 comments · Fixed by #250
Closed

Fix custom module paths #249

williamposey opened this issue Jun 4, 2024 · 0 comments · Fixed by #250
Assignees
Labels
cmp NASA GSFC CMP

Comments

@williamposey
Copy link
Contributor

The custom module path variables in CMakeLists.txt should be directly referenced, rather than their values. For example, the value of KEY_CUSTOM_PATH is checked here rather than the variable itself.

The custom module path variables in src/CMakeLists.txt should be referenced by value with their inclusion in aux_source_directory() rather than referenced directly. For example, the KEY_CUSTOM_PATH variable is refenced here directly when it should have its value referenced using expansion (${KEY_CUSTOM_PATH})

@williamposey williamposey added the cmp NASA GSFC CMP label Jun 4, 2024
@williamposey williamposey self-assigned this Jun 4, 2024
rjbrown2 added a commit that referenced this issue Jun 4, 2024
[#249] Fixed custom path cmake variable usage
@rjbrown2 rjbrown2 closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp NASA GSFC CMP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants