CryptoLib#164 - TM Multiple Packets and Pre-allocation of SA #170

jlucas9 · 2023-06-21T17:25:19Z

In order to properly compile for cFS / flight software use the security association memory needs to be pre-allocated in the structure and not dynamically allocated. This was resolved as well as some minor improvements for standalone for demonstration purposes.

…lude files

…files;

Gitlab ENV Variables do not seem to be passing to this container.

# Conflicts: # .github/workflows/mariadb.yml # CMakeLists.txt # src/sa/mariadb/sadb_routine_mariadb.template.c # test/CMakeLists.txt # test/tests/ut_kmc_crypto_with_mtls_sadb.c # util/CMakeLists.txt

…ing on build type;

…ons as well as the support and test folders entirely;

[#145] Initial Reconfiguration

…failing again;

…tion struct;

…release;

…cessing;

…purposes;

Cryptolib#159 - Key Management

# Conflicts: # src/core/crypto_tm.c

154 tm encryption support

# Conflicts: # src/core/crypto_tc.c # src/core/crypto_tm.c

codecov-commenter · 2023-06-21T17:29:09Z

Codecov Report

Merging #170 (0b113dd) into main (5beb08f) will increase coverage by 18.54%.
The diff coverage is 93.38%.

@@             Coverage Diff             @@
##             main     #170       +/-   ##
===========================================
+ Coverage   67.28%   85.83%   +18.54%     
===========================================
  Files          25       29        +4     
  Lines        9620     7629     -1991     
===========================================
+ Hits         6473     6548       +75     
+ Misses       3147     1081     -2066

Impacted Files	Coverage Δ
src/core/crypto_aos.c	`100.00% <ø> (ø)`
src/core/crypto_error.c	`34.37% <ø> (ø)`
src/core/crypto_mc.c	`82.22% <ø> (ø)`
...y/custom_stub/key_interface_custom_stub.template.c	`0.00% <0.00%> (ø)`
src/key/kmc_stub/key_interface_kmc_stub.template.c	`0.00% <0.00%> (ø)`
test/core/shared_util.c	`28.20% <ø> (ø)`
test/include/utest.h	`12.98% <ø> (ø)`
test/unit/ut_crypto_aos.c	`100.00% <ø> (ø)`
test/unit/ut_crypto_mc.c	`100.00% <ø> (ø)`
test/unit/ut_mysql_m_tls_connection.c	`0.00% <0.00%> (ø)`
... and 19 more

... and 5 files with indirect coverage changes

…freeing data;

…odome that wasn't installed;

include/crypto_config_structs.h

dccutrig

Looks pretty good! See comment wrt configuration. Minor fix on an error message string.

IbraheemYSaleh and others added 30 commits June 8, 2022 15:45

MMCSCTTL-70: Update cmake include logic to automatically grab all inc…

4b6533f

…lude files

[#145] Moved crypto modules into single source folder;

49848f0

[#145] Created sa folder with both internal and mariadb options;

296b020

[#145] Renamed src_main to core and updated .gitignore;

61fa482

[#145] Removed unused and no longer functioning sdls_ep_interop test …

cc546d5

…files;

[#145] Consolidated utils into test folder;

0ef4027

[#145] Updated readme codecov badge to look at main branch;

d89d315

[#145] Created a SUPPORT build flag and moved standalone build;

d4a40b4

[#145] Updated build flags and CMakeLists;

bb71561

Merge branch 'dev' into cryptolib#145-Config

9289714

[#145] Updates to github workflows to for PR#158;

8851670

[#145] Attempt to fix failing mariadb build for PR#158;

788b67e

Workflow, testing fixes

01118d2

Workflow Test Fixes

20d3b8b

MDB Workflow Testing

eac31cf

Workflow MDB Testing

1f6e6ef

MDB Workflow Updates

b32107c

MDB CI Workflow Testing

39ee1d1

MDB CI Workflow Test

a4023f5

MDB CI Testing

17f8537

Update mariadb.yml

0d3d5d7

Update mariadb.yml

3092483

Update mariadb.yml

9194d19

Update mariadb.yml

6136f01

MDB CI Workflow Update

ea719c2

Gitlab ENV Variables do not seem to be passing to this container.

Initial add of TM Encrypt call

9711b88

Merge branch 'dev' into cryptolib#145-Config

fe936c4

# Conflicts: # .github/workflows/mariadb.yml # CMakeLists.txt # src/sa/mariadb/sadb_routine_mariadb.template.c # test/CMakeLists.txt # test/tests/ut_kmc_crypto_with_mtls_sadb.c # util/CMakeLists.txt

[#145] Moved tests to seperate folders to allow easy inclusion depend…

acd84e0

…ing on build type;

[#145] Update codecov.yml to ignore the non-default confguration opti…

b1196ca

…ons as well as the support and test folders entirely;

Merge pull request #158 from #145-Config

1ff4287

[#145] Initial Reconfiguration

jlucas9 and others added 13 commits May 31, 2023 18:59

[#159] Updated ERR_KEY_LENGTH_ERROR to check for !=, all tests passing;

7736388

[#159] Update key interface to get_key instead of get_ek_ring, tests …

359f482

…failing again;

[#159] Key interface passing all tests, only getting one key at a time;

2e580c9

Fix TM_Apply Encryption, Add TM_Process Encryption and AES Enc only UT

83b8dc7

[#164] First attempt to have pre-allocated fields in security associa…

ea797cf

…tion struct;

[#164] Incremented CryptoLib version number as it was missed in last …

58c78a8

…release;

[#164] Comment out debugging messages in standalone with TM frame pro…

53f1128

…cessing;

[#164] Added TC debug toggle command to standalone for demonstration …

49039bf

…purposes;

Merge pull request #166 from #159-Key-Log-Mgmt

ef88a4e

Cryptolib#159 - Key Management

Merge branch 'dev' into 154-tm-encryption-support

8cd913c

# Conflicts: # src/core/crypto_tm.c

Merge pull request #168 from nasa/154-tm-encryption-support

a6eb64b

154 tm encryption support

Merge branch 'dev' into cryptolib#164-TM-Multiple-Packets

33c027f

# Conflicts: # src/core/crypto_tc.c # src/core/crypto_tm.c

[#164] Updates to support NULL IV scenarios via Crypto_Config_CryptoLib;

98fcb56

jlucas9 requested review from Isaacs740, rjbrown2, dccutrig and nfry624 June 21, 2023 17:25

jlucas9 self-assigned this Jun 21, 2023

jlucas9 added 2 commits June 21, 2023 13:46

[#164] Update CI to include test build flags and sa/mariadb to avoid …

64343c0

…freeing data;

[#164] Removed additional flag for enc_test since it requried pycrypt…

9475297

…odome that wasn't installed;

jlucas9 added the cmp NASA GSFC CMP label Jun 21, 2023

jlucas9 and others added 2 commits June 21, 2023 14:19

[#164] Change debug define for CRYPTO IS AEAD?;

5d681e9

update Error Messages

0b113dd

dccutrig reviewed Jun 21, 2023

View reviewed changes

include/crypto_config_structs.h Show resolved Hide resolved

dccutrig reviewed Jun 21, 2023

View reviewed changes

jlucas9 linked an issue Jun 22, 2023 that may be closed by this pull request

Standalone TM Multiple Packet Support #164

Closed

dccutrig merged commit 67dfb76 into main Jun 22, 2023
8 checks passed

jlucas9 deleted the cryptolib#164-TM-Multiple-Packets branch June 22, 2023 18:07

jlucas9 restored the cryptolib#164-TM-Multiple-Packets branch June 22, 2023 18:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CryptoLib#164 - TM Multiple Packets and Pre-allocation of SA #170

CryptoLib#164 - TM Multiple Packets and Pre-allocation of SA #170

jlucas9 commented Jun 21, 2023 •

edited

Loading

codecov-commenter commented Jun 21, 2023 •

edited

Loading

dccutrig left a comment

CryptoLib#164 - TM Multiple Packets and Pre-allocation of SA #170

CryptoLib#164 - TM Multiple Packets and Pre-allocation of SA #170

Conversation

jlucas9 commented Jun 21, 2023 • edited Loading

codecov-commenter commented Jun 21, 2023 • edited Loading

Codecov Report

dccutrig left a comment

Choose a reason for hiding this comment

jlucas9 commented Jun 21, 2023 •

edited

Loading

codecov-commenter commented Jun 21, 2023 •

edited

Loading