Cryptolib#159 - Key Management #166
Conversation
…Key-Log-Mgmt # Conflicts: # src/CMakeLists.txt
…NGTH up to core level from crypto;
There was a problem hiding this comment.
Reviewing this and had a thought looking over lines like the following:
extern int32_t Crypto_Config_CryptoLib(uint8_t key_type, uint8_t sadb_type, uint8_t cryptography_type, uint8_t crypto_create_fecf, uint8_t process_sdls_pdus, uint8_t has_pus_hdr, uint8_t ignore_sa_state, uint8_t ignore_anti_replay, uint8_t unique_sa_per_mapid, uint8_t crypto_check_fecf, uint8_t vcid_bitmask, uint8_t crypto_increment_nontransmitted_iv);
Should we split this config into two configuration functions? One for configuring interfaces, and one for configuring behavior?
e.g. : Crypto_Config_Interfaces(key_type, sadb_type, cryptography_type)
Crypto_Config_Behavior(crypto_create_fecf, process_sdls_pdus, has_pus_hdr, ignore_sa_state, ignore_anti_replay, unique_sa_per_mapid, crypto_check_fecf, vcid_bitmask, crypto_increment_nontransmitted_iv);
|
Added a comment to the #165 to capture Cody's input above! |
Please review and make comments as you have them!