Fix #166, improve coverage on CF_CmdGetSetParam #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites the unit test on this function in order to get full line coverage. This needs to call the routine with every defined param ID to get each case.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 18, 2022
astrogeco
added
CCB:Approved
and removed
CCB:Ready
|
CCB:2022-01-19 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Rewrites the unit test on this function in order to get full line coverage.
This needs to call the routine with every defined param ID to get each case.
Fixes #166
Testing performed
Build and run all unit tests, confirm coverage
Expected behavior changes
None for FSW, unit test coverage improvement
System(s) tested on
Ubuntu 21.10
Additional context
This also removes a bit of code from FSW that did a no-op for a size that wasn't uint32/uint16/uint8. This was unreachable because there are no cases that have such a size, and it would be a software bug if there was.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.