Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UT coverage on CF_CmdGetSetParam() #166

Closed
jphickey opened this issue Jan 12, 2022 · 0 comments · Fixed by #181
Closed

Improve UT coverage on CF_CmdGetSetParam() #166

jphickey opened this issue Jan 12, 2022 · 0 comments · Fixed by #181
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The unit test does not individually validate all of the values that "param_id" may have. This did not show up in the LCOV reports previously. However a recent PR changed the table lookup to a switch() block, the LCOV branch coverage now shows these param_id values as untested cases in the switch.

Describe the solution you'd like
Should add test cases to get back to 100% line and branch coverage.

Additional context
Note this was always the case, but it just didn't show up in the LCOV because of the code structure. Now it does.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jan 12, 2022
jphickey added a commit to jphickey/CF that referenced this issue Jan 13, 2022
Rewrites the unit test on this function in order to get full line coverage.
This needs to call the routine with every defined param ID to get each case.
astrogeco added a commit that referenced this issue Jan 18, 2022
Fix #166, improve coverage on CF_CmdGetSetParam
@skliper skliper added this to the Draco milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants