Fix #171, use osal_id_t for OSAL ID, not int32 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct typedef for OSAL ID. This also necessiates using the correct conversion macro where use as an integer is intended.
jphickey
added
the
CCB:Ready
astrogeco
approved these changes
Jan 18, 2022
astrogeco
added
CCB:Approved
and removed
CCB:Ready
|
CCB:2022-01-19 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Use the correct typedef for OSAL ID. This also necessitates using the correct conversion macro where use as an integer is intended.
Fixes #171
Testing performed
Build with OSAL bleeding edge code, confirm no type conversion errors.
Expected behavior changes
None w/Caelum OSAL, as osal_id_t is equivalent to uint32.
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.