You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In some functions, e.g. CF_WriteQueueDataToFile, CF_WriteHistoryQueueDataToFile, the OSAL file descriptor is being passed as an int32. This is incorrect, but allowed by the backward-compatibility features in OSAL. In a future version, this will become an error.
To Reproduce
Build OSAL with type-safe ID. Implicit conversion of ID to/from an integer will fail to compile.
Expected behavior
Use osal_id_t type instead, which is the correct type for an OSAL ID.
Describe the bug
In some functions, e.g. CF_WriteQueueDataToFile, CF_WriteHistoryQueueDataToFile, the OSAL file descriptor is being passed as an
int32
. This is incorrect, but allowed by the backward-compatibility features in OSAL. In a future version, this will become an error.To Reproduce
Build OSAL with type-safe ID. Implicit conversion of ID to/from an integer will fail to compile.
Expected behavior
Use
osal_id_t
type instead, which is the correct type for an OSAL ID.Code snips
CF/fsw/src/cf_utils.h
Line 224 in d3ae3f9
CF/fsw/src/cf_utils.h
Line 239 in d3ae3f9
System observed on:
Ubuntu 21.10
Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: