Skip to content

test: fix polars test_concat_diagonal_invalid again #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangotbanned merged 4 commits into from
Feb 6, 2026
+1 −1
Merged

test: fix polars test_concat_diagonal_invalid again #3451

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5575df
test: fix polars `test_concat_diagonal_invalid` again
dangotbanned Feb 4, 2026
5c24265
Merge branch 'main' into test-fix-polars-bound
dangotbanned Feb 5, 2026
cb459b9
find exact polars version
FBruzzesi Feb 6, 2026
e161761
merge main
FBruzzesi Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/frame/concat_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def test_concat_diagonal_invalid(
)
)
context: Any
if impl.is_polars() and POLARS_VERSION < (1, 1): # pragma: no cover
if impl.is_polars() and POLARS_VERSION < (1, 18): # pragma: no cover
Copy link
Member

@FBruzzesi FBruzzesi Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dangotbanned it would have taken... 17 more attempts 😂

Copy link
Member Author

@dangotbanned dangotbanned Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, I guess we'd have returned to this rabbit hole the next time these were updated.
Thanks @FBruzzesi!

narwhals/utils/generate_random_versions.py

Lines 16 to 40 in 9a15d1c

POLARS_VERSION = [
"0.20.4",
"0.20.5",
"0.20.6",
"0.20.7",
"0.20.8",
"0.20.9",
"0.20.10",
"0.20.13",
"0.20.14",
"0.20.15",
"0.20.16",
"0.20.17",
"0.20.18",
"0.20.19",
"0.20.21",
"0.20.22",
"0.20.23",
"0.20.25",
"0.20.26",
"0.20.30",
"0.20.31",
"1.0.0",
"1.1.0",
]

context = pytest.raises(
NarwhalsError,
match=re.compile(r"(int.+datetime)|(datetime.+int)", re.IGNORECASE),
Expand Down
Loading