test: fix polars test_concat_diagonal_invalid again#3451
Merged
dangotbanned merged 4 commits intomainfrom Feb 6, 2026
Merged
Conversation
Was so close in (#3434) to getting (#3407) [But fail](https://github.com/narwhals-dev/narwhals/actions/runs/21671044595/job/62478712486?pr=3449) ... maybe 5th's time the charm?
Member
|
Thanks @dangotbanned - I will run a few polars version to make sure we don't need to come bck to this again |
FBruzzesi
reviewed
Feb 6, 2026
| ) | ||
| context: Any | ||
| if impl.is_polars() and POLARS_VERSION < (1, 1): # pragma: no cover | ||
| if impl.is_polars() and POLARS_VERSION < (1, 18): # pragma: no cover |
Member
There was a problem hiding this comment.
@dangotbanned it would have taken... 17 more attempts 😂
Member
Author
There was a problem hiding this comment.
ahh, I guess we'd have returned to this rabbit hole the next time these were updated.
Thanks @FBruzzesi!
narwhals/utils/generate_random_versions.py
Lines 16 to 40 in 9a15d1c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Was so close in (#3434) to getting (#3407)
But fail ... maybe 5th's time the charm?