Skip to content

chore(typing): Preserve containers in cast_for_truediv#2355

Merged
dangotbanned merged 3 commits intomainfrom
preserve-containers-cast_for_truediv
Apr 8, 2025
Merged

chore(typing): Preserve containers in cast_for_truediv#2355
dangotbanned merged 3 commits intomainfrom
preserve-containers-cast_for_truediv

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned commented Apr 7, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Follow-up to #2350 (comment)

Original error(s) were trying to warn about dividing a Scalar by an Array.
But, with the new typing - we don't artificially introduce a Scalar as a possibility on the left-hand-side

@dangotbanned dangotbanned added internal typing pyarrow Issue is related to pyarrow backend labels Apr 7, 2025
@dangotbanned dangotbanned mentioned this pull request Apr 7, 2025
11 tasks
Copy link
Copy Markdown
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dangotbanned 😎

NarwhalsGIF

@dangotbanned dangotbanned merged commit 93e606a into main Apr 8, 2025
30 of 31 checks passed
@dangotbanned dangotbanned deleted the preserve-containers-cast_for_truediv branch April 8, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal pyarrow Issue is related to pyarrow backend typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants