Skip to content

chore: bump pyarrow-stubs==19.1#2350

Merged
MarcoGorelli merged 7 commits intomainfrom
bump-pyarrow-stubs-17.19
Apr 7, 2025
Merged

chore: bump pyarrow-stubs==19.1#2350
MarcoGorelli merged 7 commits intomainfrom
bump-pyarrow-stubs-17.19

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

@dangotbanned dangotbanned commented Apr 5, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Most of what is left is related to pc.equal missing an @overload for 2x arrays
(I goofed in zen-xu/pyarrow-stubs#184) 🤦‍♂️

https://github.com/zen-xu/pyarrow-stubs/blob/2dcbf664d85164f769149014c2f503afd649e94a/pyarrow-stubs/compute.pyi#L992-L996

greater = _clone_signature(equal)
greater_equal = _clone_signature(equal)
less = _clone_signature(equal)
less_equal = _clone_signature(equal)
not_equal = _clone_signature(equal)

@dangotbanned dangotbanned added internal typing pyarrow Issue is related to pyarrow backend labels Apr 5, 2025
@dangotbanned dangotbanned marked this pull request as ready for review April 5, 2025 18:48
@MarcoGorelli
Copy link
Copy Markdown
Member

I'm travelling so haven't had much chance to review but feel free to merge and the other typing ones if you're happy with them (I'll look over tomorrow to check there's nothing illegal)

@dangotbanned
Copy link
Copy Markdown
Member Author

I'm travelling so haven't had much chance to review but feel free to merge and the other typing ones if you're happy with them (I'll look over tomorrow to check there's nothing illegal)

Illegal 😂

@dangotbanned
Copy link
Copy Markdown
Member Author

I'm travelling so haven't had much chance to review but feel free to merge and the other typing ones if you're happy with them

Thanks @MarcoGorelli - but as a lowly member, I do still need approval to merge 🙂

@dangotbanned dangotbanned changed the title chore: bump pyarrow-stubs==17.19 chore: bump pyarrow-stubs==19.1 Apr 7, 2025
Copy link
Copy Markdown
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dangotbanned !

@MarcoGorelli MarcoGorelli merged commit ca8d63f into main Apr 7, 2025
27 of 28 checks passed
@MarcoGorelli MarcoGorelli deleted the bump-pyarrow-stubs-17.19 branch April 7, 2025 10:46
@dangotbanned
Copy link
Copy Markdown
Member Author

thanks @dangotbanned !

68747470733a2f2f692e666c756666792e63632f7a566d673963736e337064467134533668514b484b7a64436c334237635276472e676966

Thanks @MarcoGorelli!

I had one extra commit locally to fix 4 errors caused by _arrow.utils.cast_for_truediv

Do you mind if that comes in a tiny follow-up?

@MarcoGorelli
Copy link
Copy Markdown
Member

Sure no objections

@dangotbanned
Copy link
Copy Markdown
Member Author

Sure no objections

Perfect!

@MarcoGorelli fix is #2355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal pyarrow Issue is related to pyarrow backend typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants