chore: Make Polars(Expr|Series) compliant#2328
Merged
MarcoGorelli merged 7 commits intomainfrom Apr 4, 2025
Merged
Conversation
- Related #2325 (comment) - `PolarsExpr` is the source of the "new" ignore - Was hidden by using `Incomplete` ```log "PolarsSeries" is incompatible with protocol "CompliantSeries[Any]" "CompliantSeries[NativeSeriesT_co@CompliantSeries]" is not assignable to "PolarsSeries" "_to_expr" is an incompatible type Type "() -> PolarsExpr" is not assignable to type "() -> CompliantExpr[Any, PolarsSeries]" ... (reportInvalidTypeArguments) ```
Same issue as 94e3211
Still not really accurate, but the last point in the note is no longer true
dangotbanned
commented
Apr 3, 2025
Comment on lines
+171
to
+173
| def over( | ||
| self, partition_by: Sequence[str], order_by: Sequence[str] | None | ||
| ) -> Self: ... |
Member
Author
There was a problem hiding this comment.
Weird that the keys -> partition_by rename didn't show up as an issue elsewhere 🤔
dangotbanned
commented
Apr 3, 2025
Comment on lines
+656
to
+664
| to_list: Method[list[Any]] | ||
| to_pandas: Method[pd.Series[Any]] | ||
| unique: Method[Self] | ||
| var: Method[float] | ||
| zip_with: Method[Self] | ||
|
|
||
| @property | ||
| def list(self: Self) -> PolarsSeriesListNamespace: | ||
| return PolarsSeriesListNamespace(self) |
Member
Author
There was a problem hiding this comment.
Had to move list to help mypy out with the return type of to_list
See these for more info 🙂
10 tasks
MarcoGorelli
approved these changes
Apr 4, 2025
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
nice one, thanks @dangotbanned !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
group_bykeys #2325 (comment)39382c5(#2283)CompliantSeries#2236CompliantExpr#2119Checklist
If you have comments or can explain your changes, please do so below