chore: Spec `CompliantSeries` by dangotbanned · Pull Request #2236 · narwhals-dev/narwhals

dangotbanned · 2025-03-17T20:42:52Z

What type of PR is this? (check all applicable)

Related issues

Checklist

Code follows style guide (ruff)
Tests added
Documented the changes

If you have comments or can explain your changes, please do so below

- Making all of the replacements will be pretty disruptive - Just adding now for feedback in review

Will replace with something like `EagerExprNamespace` later

DIscovered a 🐛 for `IntoSeriesT`

Look at all the *now* unused ignores!!!!

narwhals/series.py

https://github.com/narwhals-dev/narwhals/actions/runs/13910411014/job/38923158466?pr=2236

Can do that in a later PR

dangotbanned · 2025-03-18T20:36:28Z

narwhals/_compliant/series.py

+    @property
+    def str(self) -> Any: ...
+    @property
+    def dt(self) -> Any: ...
+    @property
+    def cat(self) -> Any: ...
+    @property
+    def list(self) -> Any: ...
+    @property
+    def struct(self) -> Any: ...


I wanna do these properly in a follow-up

Will be similar to EagerExprNamespace

narwhals/narwhals/_compliant/expr.py

Lines 850 to 852 in a6361cd

class EagerExprNamespace(_ExprNamespace[EagerExprT], Generic[EagerExprT]):

def __init__(self, expr: EagerExprT, /) -> None:

self._compliant_expr = expr

dangotbanned · 2025-03-18T21:33:53Z

narwhals/_pandas_like/series.py

        raise AssertionError(msg)

-    def to_polars(self: Self) -> pl.DataFrame:
+    def to_polars(self: Self) -> pl.Series:


Discovering this one really was a surprise 😄

MarcoGorelli · 2025-03-19T14:56:51Z

thanks, can you fix the conflicts please?

dangotbanned · 2025-03-19T15:08:02Z

thanks, can you fix the conflicts please?

Sure thing @MarcoGorelli, won't be long

dangotbanned · 2025-03-19T15:16:38Z

narwhals/_compliant/series.py

+    def quantile(
+        self,
+        quantile: float,
+        interpolation: Literal["nearest", "higher", "lower", "midpoint", "linear"],


We should probably look into defining aliases for all of these Literal[...](s).

Or at least repeating the most common ones from polars

https://github.com/pola-rs/polars/blob/4cadeb91542de22698a038f7cbc4ef13ee6301dc/py-polars/polars/_typing.py

EdAbati

This PR looks amazing and very satisfying to me 🙌

I'd like someone else to have a look and approve because I may have missed some communication/decisions of the past couple of weeks.

MarcoGorelli

thanks @dangotbanned !

dangotbanned · 2025-03-20T11:16:18Z

Thanks @EdAbati, @MarcoGorelli

This PR looks amazing and very satisfying to me 🙌

I'd like someone else to have a look and approve because I may have missed some communication/decisions of the past couple of weeks.

That is really useful feedback @EdAbati and echoes a similar comment (#2232 (comment)) from @FBruzzesi

I should probably organize a lot of the breadcrumbs (#2230) has put down into more of a narrative.
Some of the earlier PRs listed show off a lot of the benefits you might not see through the diff alone.

Big apologies for the visibility gap on this!

FBruzzesi · 2025-03-20T11:22:59Z

I should probably organize a lot of the breadcrumbs (#2230) has put down into more of a narrative. Some of the earlier PRs listed show off a lot of the benefits you might not see through the diff alone.

@dangotbanned can you prepare a workshop/masterclass/livestream to get us to speed 😂? (Joking, but I would actually love that)

Big apologies for the visibility gap on this!

No need to apologize. Personally, I just had way less spare time in the last 3-4 weeks and chose to focus on some other features 🙈

EdAbati · 2025-03-20T11:41:43Z

Same here, no need to apologise. It's my fault. I'm also only contributing in my spare time and this varies week by week 😅😅

I actually like a lot your PR comments and descriptions! They make navigating through past PRs and issues easier 🙂

dangotbanned added 12 commits March 17, 2025 17:17

refactor: .from_iterable, .native, generic

a9952f8

refactor: Implement __narwhals_series__

3e0d816

refactor(RFC): CompliantSeries._with_native

9ac210f

- Making all of the replacements will be pretty disruptive - Just adding now for feedback in review

chore: Implement __len__

1e90cc4

promote cast

3918a0e

chore: CompliantSeries methods

3500aad

chore(DRAFT): CompliantSeries namespaces

1d89884

Will replace with something like `EagerExprNamespace` later

fix: Mark ArrowSeries.ewm_mean as not_implemented

54e2e9f

override __(eq|ne)__

7434d91

fix(typing): PandasLikeSeries.to_polars return type

3706534

narrow partial generics

0f504d0

fix(typing): Satisfy pyright

1554739

DIscovered a 🐛 for `IntoSeriesT`

dangotbanned added internal typing labels Mar 17, 2025

dangotbanned mentioned this pull request Mar 17, 2025

Formalise Compliant* protocols #2230

Closed

15 tasks

fix(typing): Satisfy mypy

9544a5d

Look at all the *now* unused ignores!!!!

dangotbanned commented Mar 17, 2025

View reviewed changes

narwhals/series.py Outdated Show resolved Hide resolved

fix: revert and adapt to_numpy

a38c9db

https://github.com/narwhals-dev/narwhals/actions/runs/13910411014/job/38923158466?pr=2236

dangotbanned mentioned this pull request Mar 18, 2025

[Bug]: TypeVar(s) used in nw.(BaseFrame|Series) are recursive #2239

Closed

dangotbanned added 4 commits March 18, 2025 19:37

Merge remote-tracking branch 'upstream/main' into compliant-series-spec

b01fc41

chore: remove some comments

2d79d10

refactor: use is_compliant_series

f917105

Merge remote-tracking branch 'upstream/main' into compliant-series-spec

48169a4

dangotbanned changed the title ~~chore(DRAFT): Spec CompliantSeries~~ chore: Spec CompliantSeries Mar 18, 2025

dangotbanned marked this pull request as ready for review March 18, 2025 20:28

revert: remove CompliantSeries._with_native

9e0611d

Can do that in a later PR

dangotbanned commented Mar 18, 2025

View reviewed changes

dangotbanned requested review from EdAbati and MarcoGorelli March 19, 2025 09:46

Merge branch 'main' into compliant-series-spec

eba34c1

Merge remote-tracking branch 'upstream/main' into compliant-series-spec

13b9b61

dangotbanned commented Mar 19, 2025

View reviewed changes

dangotbanned added 2 commits March 19, 2025 16:48

Merge remote-tracking branch 'upstream/main' into compliant-series-spec

2a37cb6

resolve more conflicts

5ff6936

dangotbanned removed request for EdAbati and MarcoGorelli March 19, 2025 21:53

Merge branch 'main' into compliant-series-spec

5ae44af

EdAbati reviewed Mar 20, 2025

View reviewed changes

MarcoGorelli approved these changes Mar 20, 2025

View reviewed changes

MarcoGorelli merged commit 8aec8fa into main Mar 20, 2025
27 of 28 checks passed

MarcoGorelli deleted the compliant-series-spec branch March 20, 2025 09:52

dangotbanned mentioned this pull request Apr 3, 2025

chore: Make Polars(Expr|Series) compliant #2328

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Spec `CompliantSeries`#2236

chore: Spec `CompliantSeries`#2236
MarcoGorelli merged 24 commits intomainfrom
compliant-series-spec

dangotbanned commented Mar 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

dangotbanned Mar 18, 2025

Uh oh!

dangotbanned Mar 18, 2025

Uh oh!

MarcoGorelli commented Mar 19, 2025

Uh oh!

dangotbanned commented Mar 19, 2025

Uh oh!

dangotbanned Mar 19, 2025 •

edited

Loading

Uh oh!

EdAbati left a comment •

edited

Loading

Uh oh!

MarcoGorelli left a comment

Uh oh!

Uh oh!

dangotbanned commented Mar 20, 2025 •

edited

Loading

Uh oh!

FBruzzesi commented Mar 20, 2025

Uh oh!

EdAbati commented Mar 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	class EagerExprNamespace(_ExprNamespace[EagerExprT], Generic[EagerExprT]):
	def __init__(self, expr: EagerExprT, /) -> None:
	self._compliant_expr = expr

Conversation

dangotbanned commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this? (check all applicable)

Related issues

Checklist

If you have comments or can explain your changes, please do so below

Uh oh!

Uh oh!

dangotbanned Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

dangotbanned Mar 18, 2025

Choose a reason for hiding this comment

Uh oh!

MarcoGorelli commented Mar 19, 2025

Uh oh!

dangotbanned commented Mar 19, 2025

Uh oh!

dangotbanned Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EdAbati left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarcoGorelli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dangotbanned commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FBruzzesi commented Mar 20, 2025

Uh oh!

EdAbati commented Mar 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dangotbanned commented Mar 17, 2025 •

edited

Loading

dangotbanned Mar 19, 2025 •

edited

Loading

EdAbati left a comment •

edited

Loading

dangotbanned commented Mar 20, 2025 •

edited

Loading