Conversation
dangotbanned
reviewed
Mar 2, 2025
dangotbanned
reviewed
Mar 2, 2025
dangotbanned
reviewed
Mar 2, 2025
Member
|
Apologies for the stream-of-consciousness @FBruzzesi 😉 |
FBruzzesi
changed the title
CompliantExpr.from_column_names to reuse in CompliantNamespace.excludeCompliantExpr.from_column_names to reuse in CompliantNamespace.<all|col|exclude>
FBruzzesi
changed the title
CompliantExpr.from_column_names to reuse in CompliantNamespace.<all|col|exclude>CompliantExpr.from_column_names to reuse for CompliantNamespace.<all|col|exclude>
Member
Author
No worries! There are a lot of good points and I as well realized I am quite happy with it now - I should have addressed all your points except comment for which I have mixed feelings. |
- `*column_names` was already positional-only - The `from_column_names` name is already explicit enough in what the first argument should be IMO
dangotbanned
approved these changes
Mar 3, 2025
Member
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
Thanks for this @FBruzzesi
I made two tweaks that I hadn't thought of yet in:
I'm approving but feel free to merge without those included, if you prefer 🙂
Member
Author
|
Thanks @dangotbanned 🙌🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Follow-up on comment