Skip to content

fix: is_in was raising when used with empty list#2031

Merged
MarcoGorelli merged 6 commits intonarwhals-dev:mainfrom
MarcoGorelli:is-in-hotfix
Feb 17, 2025
Merged

fix: is_in was raising when used with empty list#2031
MarcoGorelli merged 6 commits intonarwhals-dev:mainfrom
MarcoGorelli:is-in-hotfix

Conversation

@MarcoGorelli
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 17, 2025 14:03
@MarcoGorelli MarcoGorelli merged commit 6c66272 into narwhals-dev:main Feb 17, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant