Skip to content

perf: avoid try/except in _hasattr_static #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FBruzzesi merged 1 commit into from
Feb 14, 2025
Merged

perf: avoid try/except in _hasattr_static #2014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions narwhals/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,11 +1277,8 @@ def dtype_matches_time_unit_and_time_zone(


def _hasattr_static(obj: Any, attr: str) -> bool:
try:
getattr_static(obj, attr)
except AttributeError:
return False
return True
sentinel = object()
return getattr_static(obj, attr, sentinel) is not sentinel


def is_compliant_dataframe(obj: Any) -> TypeIs[CompliantDataFrame]:
Expand Down
Loading