perf: avoid try/except in _hasattr_static#2014
Merged
FBruzzesi merged 1 commit intonarwhals-dev:mainfrom Feb 14, 2025
Merged
Conversation
camriddell
changed the title
FBruzzesi
approved these changes
Feb 14, 2025
Member
FBruzzesi
left a comment
FBruzzesi
left a comment
There was a problem hiding this comment.
Thanks @camriddell and thanks @dangotbanned for monitoring we don't introduce overheads 🚀
Member
|
Thanks @camriddell @FBruzzesi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below
In #2011 @dangotbanned pointed out that
try/exceptis expensive in Python<3.11 and opted to use a sentinel to avoid those statements.This codepath is triggered 3 times for every call to
from_nativeso it will be regularly hit multiple times by end users so this could be worth doing.