Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FSMC driver for STM32 #661

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Add FSMC driver for STM32 #661

merged 2 commits into from
Apr 9, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Update CMake accordingly
  • Enable external SDRAM for STM32F429I-DISCOVERY
  • Updater STM32F429I-DISCOVERY target common with new RAM size

Motivation and Context

  • Satisfy the need to have more memory for managed heap

How Has This Been Tested?

  • SWO and GC app from samples repo

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@josesimoes
Add FSMC driver for STM32
d7d7d57 
- Update CMake accordingly
- Enable external SDRAM for STM32F429I-DISCOVERY
- Updater STM32F429I-DISCOVERY target common with new RAM size

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets labels Apr 7, 2018
@josesimoes josesimoes requested a review from piwi1263 April 7, 2018 02:57
@nfbot
Copy link
Member

nfbot commented Apr 7, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Add FSMC driver for STM32
a8bfb29 
- Update CMake accordingly
- Enable external SDRAM for STM32F429I-DISCOVERY
- Updater STM32F429I-DISCOVERY target common with new RAM size

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes requested review from piwi1263 and removed request for piwi1263 April 7, 2018 21:39
piwi1263
piwi1263 approved these changes Apr 8, 2018
View reviewed changes
Copy link
Member

@piwi1263 piwi1263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit 19619b1 into nanoframework:develop Apr 9, 2018
@josesimoes josesimoes deleted the add-support-fmc branch April 9, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piwi1263 piwi1263 piwi1263 approved these changes

Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josesimoes @nfbot @piwi1263