Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop target specific call #633

Merged

Conversation

Sirokujira
Copy link
Contributor

@Sirokujira Sirokujira commented Mar 1, 2018

Description

Replaced a target specific call.
chHeapAlloc is to be replaced with platform_malloc
chHeapFree is to be replaced with platform_free

Motivation and Context

platform_malloc/platform_free internal logic.
※ ChibiOS(targets/ChibiOS/common/platform_heap.c)
Already defined : The platform_malloc function internally calls chHeapAlloc.
Already defined : The platform_free function internally calls chHeapFree.

※ ESP32(targets/FreeRTOS/ESP32_DevKitC/common/platform_heap.c)
Already defined : The platform_malloc function internally calls malloc.
Already defined : The platform_free function internally calls free.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sirokujira[email protected]

@nfbot
Copy link
Member

nfbot commented Mar 1, 2018

Hi @Sirokujira,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such labels Mar 1, 2018
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit ba7547e into nanoframework:develop Mar 1, 2018
@josesimoes
Copy link
Member

Thanks! One less . Keep up the contributions. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nanoHal is wrongly using a target specific call
3 participants