Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanoHal is wrongly using a target specific call #286

Closed
Sirokujira opened this issue Feb 18, 2018 · 2 comments · Fixed by nanoframework/nf-interpreter#633
Closed

nanoHal is wrongly using a target specific call #286

Sirokujira opened this issue Feb 18, 2018 · 2 comments · Fixed by nanoframework/nf-interpreter#633
Labels
Area: Interpreter Status: FIXED Type: Enhancement
Milestone
Backlog

Comments

@Sirokujira
Copy link

Where it is a target-dependent code.
src/HAL/Include/nanoHAL.h

use chHeapAlloc/malloc, chHeapFree/free.
Why is not using the platform_malloc/platform_free function?
(Because different code uses the above function.)
@josesimoes
Copy link
Member

Hi @Sirokujira. You are correct! Thank you for catching this and reporting it! 👍

@josesimoes josesimoes changed the title There is a part not writing OS sharing code nanoHal is wrongly using a target specific call Feb 19, 2018
@josesimoes
Copy link
Member

chHeapAlloc is to be replaced with platform_malloc
chHeapFree is to be replaced with platform_free

@Sirokujira Sirokujira mentioned this issue Mar 1, 2018
Merged
10 tasks
@josesimoes josesimoes added this to the Backlog milestone Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Interpreter Status: FIXED Type: Enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Develop target specific call Sirokujira/nf-interpreter
2 participants
@josesimoes @Sirokujira