Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WriteLine implementation to Runtime.Native #1631

Merged
merged 1 commit into from
May 12, 2020
Merged

Move WriteLine implementation to Runtime.Native #1631

merged 1 commit into from
May 12, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Move WriteLine implementation to Runtime.Native.
  • Update Runtime.Native assembly declaration.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels May 12, 2020
@nfbot
Copy link
Member

nfbot commented May 12, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Move WriteLine implementation to Runtime.Native
f08ed80 
- Update Runtime.Native assembly declaration.
- Update include files in the Win32 CorLib projects.

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes merged commit 12d7f2a into nanoframework:develop May 12, 2020
@josesimoes josesimoes deleted the update-runtime-native branch May 12, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot