Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Write and WriteLine to Debug class #83

Merged
merged 1 commit into from
May 12, 2020
Merged

Add Write and WriteLine to Debug class #83

merged 1 commit into from
May 12, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add Write and WriteLine mehods to Debug class.
  • Bump version to 1.2.1-preview.
  • Bump AssemblyNativeVersion to 100.0.6.2.

Motivation and Context

  • Properly implementation of Write and WriteLine to output debug messages. Current implementation using Console.Write is technically wrong as that shouldn't be used in unattended applications according to .NET documentation.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@nfbot
Copy link
Member

nfbot commented May 12, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes mentioned this pull request May 12, 2020
Merged
10 tasks
@josesimoes
Add Write and WriteLine to Debug class
844aca6 
- Bump version to 1.2.1-preview.
- Bump AssemblyNativeVersion to 100.0.6.2.

Signed-off-by: josesimoes <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes mentioned this pull request May 12, 2020
Merged
10 tasks
@josesimoes josesimoes merged commit 90f6400 into nanoframework:develop May 12, 2020
@josesimoes josesimoes deleted the add-debug-write branch May 12, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI: Publish Release Status: Waiting for native support Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot