Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on I2C native #1333

Merged
merged 1 commit into from
May 23, 2019
Merged

Work on I2C native #1333

merged 1 commit into from
May 23, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Update native assembly declaration.
  • Implement dispose code for STM32 and TI CC32xx I2C.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Type: dependencies Pull requests that update a dependency file(s) or version labels May 23, 2019
@nfbot
Copy link
Member

nfbot commented May 23, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the work-i2c branch 2 times, most recently from 56aefac to 7c6d8fc Compare May 23, 2019 18:00
@josesimoes
Work on I2C native
88ae6e2 
- Update native assembly declaration. Following nanoframework/Windows.Devices.I2c#52.
- Implement dispose code for STM32 and TI CC32xx I2C.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes merged commit 558d143 into nanoframework:develop May 23, 2019
@josesimoes josesimoes deleted the work-i2c branch May 23, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: dependencies Pull requests that update a dependency file(s) or version Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot