Skip to content
This repository has been archived by the owner on Apr 19, 2022. It is now read-only.

Work on I2cDevice dispose #52

Merged
merged 1 commit into from
May 23, 2019
Merged

Work on I2cDevice dispose #52

merged 1 commit into from
May 23, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add argument in native dispose call to request dispose of "native controller".
  • Rename method to NativeDispose to follow general naming.

Motivation and Context

  • Passing this argument to native call helps the lower layer to make the required calls to free resources, if that the bus is no longer in use.
  • Rename method to NativeDispose to follow general naming.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@nfbot
Copy link
Member

nfbot commented May 23, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Work on I2cDevice dispose
aca0772 
- Add argument in native dispose call to request dispose of "native controller".
- Rename method to NativeDispose to follow general naming.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes merged commit 60e2edb into nanoframework:develop May 23, 2019
@josesimoes josesimoes deleted the work-native-dispose branch May 23, 2019 15:35
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request May 23, 2019
@josesimoes
Work on I2C native
12a769c 
- Update native assembly declaration. Following nanoframework/Windows.Devices.I2c#52.
- Implement dispose code for STM32 and TI CC32xx I2C.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes mentioned this pull request May 23, 2019
Merged
10 tasks
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request May 23, 2019
@josesimoes
Work on I2C native
56aefac 
- Update native assembly declaration. Following nanoframework/Windows.Devices.I2c#52.
- Implement dispose code for STM32 and TI CC32xx I2C.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request May 23, 2019
@josesimoes
Work on I2C native
7c6d8fc 
- Update native assembly declaration. Following nanoframework/Windows.Devices.I2c#52.
- Implement dispose code for STM32 and TI CC32xx I2C.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request May 23, 2019
@josesimoes
Work on I2C native
88ae6e2 
- Update native assembly declaration. Following nanoframework/Windows.Devices.I2c#52.
- Implement dispose code for STM32 and TI CC32xx I2C.

Signed-off-by: José Simões <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot