Skip to content

IsValid fns should return bool strictly #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dapplion merged 2 commits into from
Jul 28, 2023
Merged

IsValid fns should return bool strictly #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa04f18
IsValid fns should return bool strictly
dapplion Jul 12, 2023
b3e2a58
Review PR
dapplion Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions curdleproofs/curdleproofs/whisk_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,23 @@ def IsValidWhiskShuffleProof(
pre_shuffle_trackers: Sequence[WhiskTracker],
post_shuffle_trackers: Sequence[WhiskTracker],
whisk_shuffle_proof_bytes: WhiskShuffleProofBytes,
):
) -> bool:
"""
Verify `post_shuffle_trackers` is a permutation of `pre_shuffle_trackers`.
"""
try:
AssertIsValidWhiskShuffleProof(crs, pre_shuffle_trackers, post_shuffle_trackers, whisk_shuffle_proof_bytes)
return True
except: # noqa: E722
return False


def AssertIsValidWhiskShuffleProof(
crs: CurdleproofsCrs,
pre_shuffle_trackers: Sequence[WhiskTracker],
post_shuffle_trackers: Sequence[WhiskTracker],
whisk_shuffle_proof_bytes: WhiskShuffleProofBytes,
):
vec_R = [point_projective_from_bytes(tracker.r_G) for tracker in pre_shuffle_trackers]
vec_S = [point_projective_from_bytes(tracker.k_r_G) for tracker in pre_shuffle_trackers]

Expand All @@ -92,7 +105,7 @@ def IsValidWhiskShuffleProof(

whisk_shuffle_proof = WhiskShuffleProof.from_bytes(BufReader(whisk_shuffle_proof_bytes), n)

return whisk_shuffle_proof.proof.verify(crs, vec_R, vec_S, vec_T, vec_U, whisk_shuffle_proof.M)
whisk_shuffle_proof.proof.verify(crs, vec_R, vec_S, vec_T, vec_U, whisk_shuffle_proof.M)


def GenerateWhiskShuffleProof(
Expand Down Expand Up @@ -138,10 +151,22 @@ def IsValidWhiskOpeningProof(
"""
Verify knowledge of `k` such that `tracker.k_r_G == k * tracker.r_G` and `k_commitment == k * BLS_G1`.
"""
try:
AssertIsValidWhiskOpeningProof(tracker, k_commitment, tracker_proof)
return True
except: # noqa: E722
return False


def AssertIsValidWhiskOpeningProof(
tracker: WhiskTracker,
k_commitment: BLSPubkey,
tracker_proof: SerializedWhiskTrackerProof,
):
tracker_proof_instance = TrackerOpeningProof.from_bytes(BufReader(tracker_proof))

transcript_verifier = CurdleproofsTranscript(b"whisk_opening_proof")
return tracker_proof_instance.verify(
tracker_proof_instance.verify(
transcript_verifier,
point_projective_from_bytes(tracker.k_r_G),
point_projective_from_bytes(tracker.r_G),
Expand Down