Skip to content

IsValid fns should return bool strictly#21

Merged
dapplion merged 2 commits intomasterfrom
isvalid
Jul 28, 2023
Merged

IsValid fns should return bool strictly#21
dapplion merged 2 commits intomasterfrom
isvalid

Conversation

@dapplion
Copy link
Copy Markdown
Collaborator

Just return bool to conform with the API defined in the spec

asn-d6
asn-d6 previously requested changes Jul 14, 2023
Copy link
Copy Markdown
Collaborator

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of this huge indented try blocks. Can you split the func into func() and func_impl() and have func_impl() do all the stuff, and then have func() call func_impl() and do the try return value logic? Maybe that would look better?

@dapplion
Copy link
Copy Markdown
Collaborator Author

Not a big fan of this huge indented try blocks. Can you split the func into func() and func_impl() and have func_impl() do all the stuff, and then have func() call func_impl() and do the try return value logic? Maybe that would look better?

IsValid* fns wrap AssertIsValid* which contain the not indented implementation

@dapplion dapplion merged commit bc4bb34 into master Jul 28, 2023
@dapplion dapplion deleted the isvalid branch July 28, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants