Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert less to use bootstrap variables and mixins #136

Merged
merged 1 commit into from
Nov 23, 2015

Conversation

Julusian
Copy link
Contributor

The changes look like more than there is, as a different version of less appears to be in use.

@nakupanda
Copy link
Owner

Hi,

Just tried your changes and found font was small than before, will give you more feedback later.

Thanks for you contribution!

@Julusian
Copy link
Contributor Author

It looks like something weird is going on with the css/less i forked from.
It appears that your css files arent compiled from the current version of the less.
I have created another pull request to fix this.
#137

@nakupanda
Copy link
Owner

You're right, the less file was created by other contributor based on the css file that had been written, I think during the process something was missing.

@fabn
Copy link
Contributor

fabn commented Nov 20, 2015

Could this be rebased to use latest version? It would be very useful to use less file as is instead of copying and pasting it only to add default bootstrap variables.

@Julusian
Copy link
Contributor Author

I've just pushed a rebased version

nakupanda added a commit that referenced this pull request Nov 23, 2015
Convert less to use bootstrap variables and mixins
@nakupanda nakupanda merged commit e457069 into nakupanda:master Nov 23, 2015
nakupanda added a commit that referenced this pull request Nov 23, 2015
@nakupanda
Copy link
Owner

Merged into master, thank you.

If possible, I would suggest exporting .less file to /dist/less directory too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants